Add skew functionality to pygame.transform #2143
Conversation
Temmie3754
changed the title
|
Just two comments regarding this pull request:
|
|
zoldalma999
added
New API
I do see use cases for this, but it may be redundant. Another thread involves mapping a surface to new points. This skew functionality could be achieved using that method. Although that thread hasn't seen much activity... |
|
I like the name skew, it is familiar to me for this type of operation (and is the sort of word I'd look for in a transform submodule to get this effect). Photoshop and GIMP use I'm happy having a function like this even if you could achieve the same thing with a more complicated warping function as it is likely that users would look for something like this and might not grasp that a more complicated function could be used for the same thing. If needed we could eventually reduce underlying code duplication by making this API call the more complicated spatial transform with some fixed parameters. |
Co-authored-by: Dan Lawrence <[email protected]>
There was a problem hiding this comment.
Tried this out finally. Unfortunately, there is no test or usage example and when I tired to use it like so:
import pygame
display_surf = pygame.display.set_mode((1280, 600))
display_surf.fill((255, 255, 255))
walt = pygame.image.load("images/walt.png").convert_alpha()
walt_2 = pygame.transform.skew(walt, [[0, 0], [417, 0], [0, 364], [417, 364]])
walt_3 = pygame.transform.skew(walt, [[0, 0], [417, 0], [0, 364], [417, 364]])
pygame.init()
clock = pygame.time.Clock()
running = True
while running:
for event in pygame.event.get():
if event.type == pygame.QUIT:
running = False
display_surf.fill((255, 255, 255))
display_surf.blit(walt, (0, 100))
display_surf.blit(walt_2, (417, 100))
display_surf.blit(walt_3, (834, 100))
pygame.display.flip()
clock.tick(60)I get a segmentation fault.
I may be doing it wrong, but in any case we defintely need some clearer documentation on the four points and the order they are supplied in. I'm assuming it goes - [top_left, top_right, bottom_left, bottom_right] but I could be wrong. I'm also assuming the supplied points are in pixels.
Anyway, I think this could be cool if it worked.
|
Will probably need to write some tests for this and maybe some further changes to the docs but otherwise at this point I think it is fully functional, unless anyone else has other ideas for this PR. |
Co-authored-by: Damiano <[email protected]>
src_c/transform.c
Outdated
| } | ||
| } | ||
| else { | ||
| if (!pg_MappedColorFromObj(colorobj, surf->format, &bgcolor, |
There was a problem hiding this comment.
A PR has been merged that requires the surface itself (not the format). Since you are not using _color_from_obj anymore, you should move it back from where you moved it, which should fix the merge conflicts.
This adds a skew function to the transform module as requested by #2098 with modifications to support inputs of any 4 coordinates to map the surface to. Do note this is still a WIP so the full implementation for release has not been completed, feel free however to test out the current algorithm implementation and submit feedback on it.